Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publishing Postgres constructor, update Postgres_Details.Postgres to Postgres.Server. #10466

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Jul 6, 2024

Pull Request Description

image

  • Rename Postgres_Details to Postgres.
  • Rename Postgres constructor to Server.
  • Update SPI.
  • Linting issues (indent, missing doc comment)

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

Rename `Postgres` constructor to `Server`.
Update SPI.
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jul 8, 2024
@mergify mergify bot merged commit 018d4c3 into develop Jul 8, 2024
37 checks passed
@mergify mergify bot deleted the wip/jd/postgres-constructor branch July 8, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants